| lkcl | cesar[m]1, the patch looks good, one correction 23-i rather than 32-i on the for i,x in enumerate(rm_fields) | 16:20 |
|---|---|---|
| cesar[m]1 | Thanks, will push. | 16:23 |
| programmerjake[m | really should use named constants ... that way typos are easier to catch | 16:30 |
| lkcl | ahh i did this in soc.consts... | 16:31 |
| lkcl | cesar[m]1, jacob has a good point. see soc/consts.py | 16:31 |
| lkcl | and the aptly-named "botchify" function :) | 16:31 |
| lkcl | you can have two classes, NNNN and NNNNb, and botchify() will automatically enumerate all properties and subtract from 63 :) | 16:32 |
| lkcl | i am just adding an extra argument | 16:32 |
| programmerjake[m | that works too, but I meant changing `32 - i` to `WHATEVER_WIDTH - i` | 16:33 |
| lkcl | yes - the botchify function will populate a class with the WHATEVER_WIDTH-i automatically if you give it a class containing LE (or BE) | 16:34 |
| lkcl | if you pass it a class with LE it creates the BE, and vice-versa | 16:34 |
| lkcl | goodbye 32-i and WHATEVER-i | 16:34 |
| cesar[m]1 | Interesting. I will put the SVP64 field definitions in consts.py and redo the patch. Also, I will replace all the shifts by calls to field(). | 17:31 |
| cesar[m]1 | ... and SelectableInt for SVP64Asm, I guess. | 17:45 |
| lkcl | cesar[m]1, simply commit as-is first then do the consts.py second | 21:01 |
| lkcl | because it's a different purpose. | 21:01 |
| lkcl | one commit, one purpose | 21:01 |
| lkcl | if you are ever tempted to put the word "and" into a commit message, or to subdivide it into different bullet-points for example, that's a sign of "separate commits" | 21:02 |
| cesar[m]1 | Got it. | 21:08 |
| lkcl | meeting 15-ish mins | 21:43 |
| lkcl | lxo programmerjake[m cesar[m]1 ^ | 21:43 |
| programmerjake[m | Phoronix mentioned Libre-SOC in the list of articles in https://www.phoronix.com/scan.php?page=news_item&px=Vulkan-Turns-Five-Years-Old | 21:54 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!