| lkcl | tests passed, all pushed | 00:06 |
|---|---|---|
| lkcl | programmerjake, anything under bug #254 i did say hasn't been approved yet | 00:15 |
| lkcl | i put one in with a copy of the explicit instructions to Michiel so that he could review and action the changes (which include utf-8, which isn't strictly "3D") hence the need for him to review and approve it | 00:16 |
| lkcl | can you please re-submit, with *only* the Transcendentals for now? give it a few days i'll let you know when Michiel's reviewed | 00:18 |
| lkcl | ghostmansd[m], you can also put in #899 https://bugs.libre-soc.org/show_bug.cgi?id=899 | 00:18 |
| lkcl | but don't put any others under 3D/Vulkan yet (anything connected to #254) | 00:18 |
| lkcl | please remove the "submitted" dates from #794 and #911 and wait until i've got confirmation | 00:20 |
| lkcl | and redo *only* an RFP for #899 | 00:20 |
| lkcl | ghostmansd[m], you can also put in EUR 2500 for #898 https://bugs.libre-soc.org/show_bug.cgi?id=898 | 00:22 |
| lkcl | but put it as an RFP under the *parent*, #252 | 00:23 |
| lkcl | then use the "notes" from this page https://libre-soc.org/task_db/mdwn/ghostmansd/ | 00:23 |
| lkcl | i'll email you instructions | 00:23 |
| programmerjake | lkcl, done | 00:28 |
| lkcl | star | 00:28 |
| lkcl | nuisance the need to run things by michiel, but it means better auditing. sigh | 00:29 |
| lkcl | got it | 00:32 |
| * lkcl checking | 00:32 | |
| lkcl | yeah all good | 00:32 |
| lkcl | as #252 has had all its tasks 100% completed the RFPs can go in no problem | 00:33 |
| lkcl | #254 not so much | 00:33 |
| programmerjake | k, ttyl -- woke up really early (3am) so need sleep | 00:34 |
| lkcl | :) | 00:34 |
| *** zemaye <zemaye!~zemaye@31-209-215-224.dsl.dynamic.simnet.is> has joined #libre-soc | 02:47 | |
| *** zemaye <zemaye!~zemaye@31-209-215-224.dsl.dynamic.simnet.is> has quit IRC | 03:05 | |
| *** yambo <yambo!~yambo@69.146.1.110> has quit IRC | 06:04 | |
| *** yambo <yambo!~yambo@69.146.1.110> has joined #libre-soc | 06:19 | |
| *** lxo <lxo!~lxo@gateway/tor-sasl/lxo> has quit IRC | 07:30 | |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has joined #libre-soc | 09:31 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has quit IRC | 10:23 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.53.190> has joined #libre-soc | 10:24 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.53.190> has quit IRC | 10:42 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.53.190> has joined #libre-soc | 10:45 | |
| *** midnight <midnight!~midnight@user/midnight> has quit IRC | 11:12 | |
| *** midnight <midnight!~midnight@user/midnight> has joined #libre-soc | 11:13 | |
| lkcl | ghostmansd[m], programmerjake 794 871 911 and 917 have now all been added to the MoU so RFPs for those can be submitted | 12:05 |
| ghostmansd[m] | Oh cool! | 12:06 |
| ghostmansd[m] | Thanks, will submit today | 12:07 |
| lkcl | just sending you an email on the "comments" to be included | 12:09 |
| lkcl | you must put the RFP under #252 (covering multiple bugreports) and under #911. | 12:10 |
| lkcl | programmerjake, vulkan RFP approved by NLnet | 12:11 |
| lkcl | and Video RFP approved as well | 12:11 |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.53.190> has quit IRC | 12:35 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.54.18> has joined #libre-soc | 12:36 | |
| *** philpax_ <philpax_!sid516926@id-516926.lymington.irccloud.com> has quit IRC | 13:01 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.54.18> has quit IRC | 13:01 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.54.178> has joined #libre-soc | 13:02 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.54.178> has quit IRC | 13:06 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has joined #libre-soc | 13:07 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has joined #libre-soc | 13:54 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has quit IRC | 14:09 | |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has quit IRC | 14:17 | |
| *** lxo <lxo!~lxo@gateway/tor-sasl/lxo> has joined #libre-soc | 15:22 | |
| lkcl | ping ghostmansd[m] python3 src/openpower/sv/trans/test_pysvp64dis.py > /tmp/f | 15:26 |
| lkcl | ERROR: test_2_d_custom_op (__main__.SVSTATETestCase) | 15:26 |
| lkcl | i posted more in #917 i think | 15:26 |
| ghostmansd[m] | Aha, checking | 15:27 |
| lkcl | that was just after the addition of SignedOperand | 15:28 |
| ghostmansd[m] | Yeah this one is signed | 15:28 |
| ghostmansd[m] | Likely DOperatorDX was broken, IIRC addpcis used it | 15:29 |
| lkcl | programmerjake, you can put in.... err... #794 and #791 now | 15:29 |
| lkcl | yes. | 15:29 |
| lkcl | ironically fmvis and fishmv are unsigned decimal | 15:29 |
| lkcl | but still use D-Field | 15:30 |
| lkcl | (whoops) | 15:30 |
| ghostmansd[m] | Hm | 15:30 |
| ghostmansd[m] | We should sort these out on per-insteuction basis, then... | 15:30 |
| ghostmansd[m] | Because currently they use signed. | 15:31 |
| ghostmansd[m] | Or, well, on per-form format. | 15:31 |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has joined #libre-soc | 15:31 | |
| ghostmansd[m] | lkcl, by the way, these d0,d1,d2 are documented as signed | 15:31 |
| ghostmansd[m] | So we might need docs update | 15:32 |
| ghostmansd[m] | Or have different names for operands | 15:33 |
| ghostmansd[m] | Aaaaah yes | 15:36 |
| ghostmansd[m] | Ok I see the problem, this gets the same D operand as any other instruction with D operands | 15:36 |
| lkcl | good job there's unit tests, eh? :) | 15:37 |
| ghostmansd[m] | Yes, that's really helps a lot! | 15:37 |
| ghostmansd[m] | OK all but SPR is fine | 15:37 |
| ghostmansd[m] | I recall you did some tricks with it | 15:38 |
| lkcl | i couldn't help but hear that in a sarcastic voice :) "grumble grumble oh thanks a loooot" :) | 15:38 |
| lkcl | yes, it works fine now | 15:38 |
| lkcl | re-run pywriter noall sprset | 15:38 |
| lkcl | whatever errors you're getting will go walkies | 15:38 |
| ghostmansd[m] | Aaaaah yes this is always forgotten | 15:38 |
| lkcl | i changed the pseudocode "n <- spr[blah] || spr[blah]" | 15:38 |
| lkcl | to just | 15:39 |
| lkcl | "n <- spr" | 15:39 |
| lkcl | oh you saw i added madd* yesterday? | 15:39 |
| lkcl | they passed first time | 15:39 |
| ghostmansd[m] | Pushed fix for addpcis | 15:40 |
| programmerjake | lkcl, put in rfp for #794 and #911 | 15:40 |
| ghostmansd[m] | Hm, SPR still doesn't work on my side | 15:40 |
| lkcl | programmerjake, yep got it, all good | 15:40 |
| lkcl | ghostmansd[m], 1 sec | 15:40 |
| programmerjake | #791 is the wrong bug id | 15:41 |
| lkcl | ghostmansd[m], you're on commit c22949b84c8d7087? | 15:41 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has joined #libre-soc | 15:42 | |
| ghostmansd | 008d1d272f14aa7bd7dc7e71c20ab9f00ce06572 | 15:42 |
| ghostmansd | The one I just pushed | 15:42 |
| ghostmansd | previous is c22949b84c8d708705357f8926016fd11104a4d6 | 15:42 |
| lkcl | ack 1 sec | 15:42 |
| ghostmansd | I see sprset.mdwn change, though | 15:42 |
| lkcl | python3 src/openpower/sv/trans/test_pysvp64dis.py > /tmp/f | 15:43 |
| lkcl | Ran 9 tests in 4.658s | 15:43 |
| lkcl | OK | 15:43 |
| ghostmansd[m] | Ah damn | 15:43 |
| ghostmansd[m] | I know, Talos version needs to be pulled | 15:43 |
| lkcl | doh :) | 15:43 |
| ghostmansd[m] | Yeah fine now | 15:44 |
| ghostmansd[m] | False alarm | 15:44 |
| lkcl | wark-wark :) | 15:45 |
| ghostmansd[m] | Ok, back to D operand for addpcis/fishmv/fmvis | 15:45 |
| ghostmansd[m] | This should be signed for addpcis but not for FP, right? | 15:45 |
| ghostmansd[m] | so we have different D operand composed from dX chunks | 15:46 |
| programmerjake | note on the latest commit that finished ci on openpower-isa.git master (c22949b8): | 15:47 |
| programmerjake | FAILED src/openpower/decoder/test/test_power_decoder.py::DecoderTestCase::test_minor_19 | 15:47 |
| programmerjake | FAILED src/openpower/sv/trans/test_pysvp64dis.py::SVSTATETestCase::test_2_d_custom_op | 15:47 |
| ghostmansd[m] | Yeah should be fixed in the recent master | 15:51 |
| programmerjake | i'd expect test_minor_19 to still be broken, lkcl can you fix it since you broke it by changing minor_19.csv to pattern rather than integer | 15:53 |
| ghostmansd[m] | lkcl, programmerjake, would you object if I add disassembly produced with sv_binutils_fptrans as one of the tests to test_svp64dis.py? | 16:09 |
| ghostmansd[m] | This won't increase CI terribly, but still the test will take longer (all fptrans instructions with min/max operands permutations). | 16:10 |
| ghostmansd[m] | I'll need to tune sv_binutils_fptrans to make it reusable (it produces the output in binutils-like form), but still I find the idea attractive. | 16:11 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has quit IRC | 16:15 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has quit IRC | 16:32 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.174.71> has joined #libre-soc | 16:33 | |
| *** lxo <lxo!~lxo@gateway/tor-sasl/lxo> has quit IRC | 16:39 | |
| programmerjake | sounds fine to me! | 16:40 |
| programmerjake | lkcl: yup, test_minor_19 failed for oprnpower-isa 008d1d27 | 16:55 |
| programmerjake | please fix it soon | 16:56 |
| ghostmansd[m] | I can do it later today, approximately 4 hours later. Is the only issue that it should be pattern, not an integer? | 16:59 |
| programmerjake | no, the issue is that the csv was changed to be a pattern rather than an integer and the test wasn't updated at the same time, so it fails to parse the csv properly | 17:00 |
| programmerjake | https://salsa.debian.org/Kazan-team/mirrors/openpower-isa/-/jobs/3244125 | 17:01 |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has quit IRC | 17:18 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.174.71> has quit IRC | 17:39 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has joined #libre-soc | 17:40 | |
| ghostmansd[m] | Ok, got it! | 17:53 |
| ghostmansd[m] | I've just submitted tests for fptrans, now we have 10 tests, and one of them checks 232 instructions. | 17:55 |
| lkcl | tests still good as of ae876 | 19:03 |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has joined #libre-soc | 19:08 | |
| programmerjake | at ae876: | 20:14 |
| programmerjake | FAILED src/openpower/decoder/test/test_power_decoder.py::DecoderTestCase::test_minor_19 | 20:14 |
| *** octavius <octavius!~octavius@46.125.93.209.dyn.plus.net> has quit IRC | 20:19 | |
| ghostmansd[m] | Checking this | 20:37 |
| ghostmansd[m] | Just got to the laptop | 20:37 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has joined #libre-soc | 20:42 | |
| ghostmansd[m] | Nah it's already pattern. Checking what went wrong exactly. | 20:42 |
| ghostmansd[m] | Ok it simply needs to be marked as opint in test it seems. | 20:48 |
| ghostmansd[m] | That said, we should drop these explicit opint eventually... I just don't have time for it now, but the idea is the same: we can iterate over insndb, each instruction has the "section" field where it's specified whether it's opint (or, actually, there's a enum of pattern/integer). | 20:50 |
| ghostmansd[m] | Pushed the fix, CI should be fine now. | 20:50 |
| *** lxo <lxo!~lxo@linux-libre.fsfla.org> has joined #libre-soc | 21:45 | |
| programmerjake | ci passed, thx! | 21:48 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-188-32-220-156.ip.moscow.rt.ru> has quit IRC | 21:49 | |
| lkcl | hmmm that's a neat trick on test_9_fptrans sv/trans/test_pysvp64dis.py | 22:45 |
| lkcl | i wonder if it can be replicated for auto-generation of every single instruction/ | 22:45 |
| lkcl | plus some automatic unit test assembler | 22:46 |
| lkcl | asmop 1,1 | 22:46 |
| lkcl | asmop 31,7 # 1st field is 5-bit, 2nd field is 3-bit | 22:46 |
| lkcl | and all permutations in between, 0 1 2 4 8 16 then 31 | 22:47 |
| lkcl | hmm hmm | 22:48 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!