| *** kylel <kylel!~Thunderbi@2601:805:4200:aa20::85b0> has quit IRC | 02:32 | |
| *** lxo <lxo!~lxo@gateway/tor-sasl/lxo> has quit IRC | 04:24 | |
| *** lxo <lxo!~lxo@gateway/tor-sasl/lxo> has joined #libre-soc | 05:14 | |
| lkcl | Las[m], the heuristic for running appropriate unit tests i went through it with ghostmansd and kylel quite recently | 05:23 |
|---|---|---|
| lkcl | it needs becoming a bit familiar with the dependency hierarchy of the code, but basically the further up towards "unused" or "little-used" leaf node code, the less unit tests you need to run [with semi-confidence] | 05:25 |
| lkcl | there's a few "big" tests (25 mins) and some REALLY big tests (several days) | 05:26 |
| lkcl | the heuristics allow you to avoid running those on every single commit | 05:26 |
| lkcl | one trick: | 05:27 |
| lkcl | * write completely independent code that is totally isolated from all other code. | 05:27 |
| lkcl | * commit it freely even without unit tests (not really encouraged, that) as long as it has no syntax errors | 05:28 |
| lkcl | * write completely independent unit tests, again committing those freely without reservation | 05:28 |
| lkcl | (i mean, *not* even using branches, because there's absolutely zero possibility of "damage") | 05:29 |
| lkcl | * once and ONLY once you are happy that the (independent) code actually works, work out how to "hook" it into "live" code | 05:30 |
| lkcl | this last part may need some preliminary / preparatory code-morphs before the "live" code is ready to "accept" the (up until then independent) code | 05:30 |
| lkcl | it's an incremental process and it's one we're literally going through right now with the Test API | 05:31 |
| lkcl | so if you track the commits made across the soc and openpower-isa repos here https://bugs.libre-soc.org/show_bug.cgi?id=686 | 05:32 |
| lkcl | you can get a pretty clear idea of how *not* to need to use branches | 05:32 |
| lkcl | which i detest | 05:32 |
| lkcl | having had quite significant work *completely* disregarded, multiple times, because i was told "f*** off and use branches, moron" | 05:33 |
| lkcl | i'm not about to inflict that onto anyone else. | 05:33 |
| lkcl | that said, the XLEN work which required very careful review, used an xlen branch, and it worked extremely well. | 05:34 |
| lkcl | that involved cherry-picking of something mad like *100* small commits, but it set up a good review process. similar to how gerrit works, but without needing a horror-show-of-web-service | 05:36 |
| *** xiews <xiews!~wxie@116.236.173.162> has joined #libre-soc | 05:37 | |
| programmerjake | lkcl, if your still up, do the budget-sync changes sound good? (feel free to review/test tomorrow) | 05:42 |
| lkcl | programmerjake, i'm a schrodinger cat at the moment :) | 05:43 |
| programmerjake | hmm, sleep and look in the morning? | 05:44 |
| *** xiews <xiews!~wxie@116.236.173.162> has quit IRC | 05:45 | |
| *** xiews <xiews!~wxie@116.236.173.162> has joined #libre-soc | 05:51 | |
| *** xiews <xiews!~wxie@116.236.173.162> has quit IRC | 05:57 | |
| *** xiews <xiews!~wxie@222.64.216.101> has joined #libre-soc | 06:05 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!