| lkcl | programmerjake, do remember to update fields.txt. MMM-Form looks good | 04:21 |
|---|---|---|
| lkcl | on https://bugs.libre-soc.org/show_bug.cgi?id=1064 (and all new bugs) | 04:24 |
| lkcl | please please always always put at least one "see also" or "depends" or "blocks" | 04:24 |
| lkcl | in this case search "XLEN" and put pretty-much-everything-related onto that one | 04:24 |
| lkcl | otherwise the bugs get hopelessly lost | 04:25 |
| lkcl | 6 months or greater go by before they're encountered by accident | 04:25 |
| programmerjake | i did, 1061 | 04:25 |
| programmerjake | so, do the xlen changes look good, can i push it to master? | 04:29 |
| programmerjake | apparently not, ci failed | 04:42 |
| programmerjake | fun...XLCASTU is broken: | 04:48 |
| programmerjake | def XLCASTU(self, value): | 04:48 |
| programmerjake | # SelectableInt already takes care of masking out the bits | 04:48 |
| programmerjake | > return SelectableInt(value.value, self.XLEN) | 04:48 |
| programmerjake | E AttributeError: 'int' object has no attribute 'value' | 04:48 |
| programmerjake | ok, fixed it: https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=edabfe28a532036bc83b1661f45fa5b850a4acab;hp=75d9fc62dc34efeba2b395564bd1579ed29a0c14 | 05:05 |
| programmerjake | lkcl: does that look good? | 05:05 |
| lkcl | mmm i prefer not changing function names, introducing new concepts of "casting" is a bad idea | 05:59 |
| lkcl | stick with EXTZ as that is understood | 05:59 |
| programmerjake | I didn't change them, I just used the existing functions we already have... | 05:59 |
| lkcl | those functions do not exist in Power ISA v3.1 | 05:59 |
| lkcl | the functions named "CAST" should not have been added with those names | 06:00 |
| programmerjake | k | 06:00 |
| lkcl | they need to be renamed EXTZxxx and EXTSxxx | 06:00 |
| lkcl | because the concept of "casting" is foreign/unknown to the Power ISA document | 06:00 |
| lkcl | whereas sign-extending and zero-extending are long-established | 06:00 |
| programmerjake | yeah, I originally tried to use EXTZXL, but it didn't exist | 06:01 |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 17:52 | |
| *** gnucode <gnucode!~gnucode@user/jab> has joined #libre-soc | 19:18 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 19:38 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 19:38 | |
| *** gnucode <gnucode!~gnucode@user/jab> has quit IRC | 20:16 | |
| *** gnucode <gnucode!~gnucode@user/jab> has joined #libre-soc | 20:16 | |
| *** gnucode <gnucode!~gnucode@user/jab> has quit IRC | 22:22 | |
| *** gnucode <gnucode!~gnucode@user/jab> has joined #libre-soc | 22:22 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!