| *** yambo <yambo!~yambo@069-145-110-003.biz.spectrum.com> has joined #libre-soc | 01:50 | |
| programmerjake | I did some more profiling and, for the part of the utf-8 tests I profiled, something like 80% of the simulator's run-time is taken up by nmigen simulating the decoder...since ghostmansd has written insndb which iirc can do the full decoding process, I think we should switch ISACaller to use that instead of the nmigen-simulated decoder, it'll likely run >2x as fast | 03:41 |
|---|---|---|
| programmerjake | this doesn't have to happen right now... | 03:41 |
| programmerjake | (discovering that was a bit unexpected for me, I was expecting most the runtime to be used up by executing the pseudocode) | 03:43 |
| programmerjake | profiling command I ran: | 03:44 |
| programmerjake | `(py-spy record -f speedscope -o prof.json -- pytest --full-trace -n 0 -v src/openpower/decoder/isa/test_caller_svp64_utf_8_validation.py& pid=$!; sleep 30; kill -SIGINT $!; wait)` | 03:44 |
| programmerjake | oh, whoops, just realized I never used the $pid variable...guess it worked anyway :) | 03:45 |
| programmerjake | getting a backtrace from a generator that isn't currently running is a bit annoying... | 03:46 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 07:27 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 08:19 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 08:39 | |
| *** TheDot <TheDot!~TheDot@d66-244-245-228.abol1.o-net.ca> has quit IRC | 08:47 | |
| *** TheDot <TheDot!~TheDot@d66-244-245-228.abol1.o-net.ca> has joined #libre-soc | 08:48 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 09:10 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 09:23 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 09:23 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 09:32 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 09:49 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.40.250> has joined #libre-soc | 09:50 | |
| *** octavius <octavius!~octavius@92.40.168.179.threembb.co.uk> has joined #libre-soc | 13:00 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.40.250> has quit IRC | 13:17 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 13:18 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 13:23 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 13:32 | |
| *** octavius <octavius!~octavius@92.40.168.179.threembb.co.uk> has quit IRC | 13:53 | |
| *** sauce <sauce!~sauce@2a07:9944:2222:1d::a> has quit IRC | 14:37 | |
| *** sauce <sauce!~sauce@free.and.open.sauce.icu> has joined #libre-soc | 14:37 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 15:36 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.41.64> has joined #libre-soc | 15:37 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.41.64> has quit IRC | 15:55 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@46.39.248.54> has joined #libre-soc | 15:56 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@46.39.248.54> has quit IRC | 16:18 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.41.137> has joined #libre-soc | 16:20 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@176.59.41.137> has quit IRC | 16:44 | |
| *** ghostmansd[m] <ghostmansd[m]!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 16:46 | |
| *** sauce <sauce!~sauce@free.and.open.sauce.icu> has quit IRC | 16:57 | |
| *** sauce <sauce!~sauce@free.and.open.sauce.icu> has joined #libre-soc | 17:02 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 17:59 | |
| lkcl | programmerjake, yes absolutely - i really want to do that, but it's a massive job | 18:03 |
| lkcl | all instances of "yield" have to go - hundreds of them throughout the *entirety* of ISACaller | 18:03 |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has quit IRC | 19:05 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 19:05 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has left #libre-soc | 19:05 | |
| *** ghostmansd <ghostmansd!~ghostmans@broadband-109-173-83-100.ip.moscow.rt.ru> has joined #libre-soc | 19:06 | |
| *** tplaten <tplaten!~tplaten@195.52.49.147> has joined #libre-soc | 19:18 | |
| ghostmansd | lkcl, any updates or estimations on questions in 1094? Any implementation-wise comments? | 19:23 |
| ghostmansd | The task is assigned to you, these two are show stoppers for me. | 19:24 |
| *** tplaten <tplaten!~tplaten@195.52.49.147> has quit IRC | 21:11 | |
| lkcl | ghostmansd, hiya sorry been speaking with my friend from HK i haven't seen in 3 years. i read it, just haven't replied yet | 21:11 |
| lkcl | i'm really happy with the API, and how it works: it's a frickin awesome piece of work and extremely important, it'll literally be the bedrock of everything we do | 21:12 |
| lkcl | i mean: eeeverything (!) | 21:12 |
| lkcl | can i suggest nodeid as it's really short? | 21:13 |
| lkcl | @_contextlib.contextmanager | 21:13 |
| lkcl | def __call__(self, nodeid, node): | 21:14 |
| lkcl | ... | 21:14 |
| ghostmansd[m] | Sorry, missing a bit. What do you mean by nodeid? | 21:21 |
| ghostmansd[m] | FWIW, the API is generic enough. For dict, for example, it will traverse both keys and values. | 21:22 |
| ghostmansd[m] | (of course depending on what the hook does) | 21:22 |
| ghostmansd[m] | cf. section "walkers" here: https://repo.or.cz/mdis.git | 21:24 |
| ghostmansd[m] | No rush, just wanted to confirm you didn't miss my comments. | 21:25 |
| ghostmansd[m] | When you have time, could you please estimate pros and cons of where this module should rest (I doubt it should be a different repo, even though totally open source?, and whether we need it in pypi, and so on and so on. | 21:26 |
| ghostmansd[m] | And, also, please keep in mind that we really, really need to invent some criteria on what we accept and what we ban. | 21:27 |
| ghostmansd[m] | The latter is of no rush, but I think we should have such document eventually. | 21:27 |
| ghostmansd[m] | If you think the design is OK, and you came to conclusion on how to incorporate it (PyPI, part of openpower-isa, our own repo, or even repo.or.cz or other server), please ping me on your thoughts and update the task. It's been hanged on you by me, I reassigned it and changed the budget, please edit as you feel appropriate. But first I need your decisions. | 21:29 |
| ghostmansd[m] | I like if it's both on some repository and in PyPI too, because I'd like of others could use this concept for totally different needs. However, I think relying on repo.or.cz is a bit way too brave assumption. | 21:45 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!